MPA

From the to-do list: MPA V1.0: Older issues and tasks

✔ Tasks panel: hang when 3 tasks completed

Comments

Pierre henri Seylan on May 28, 2018:

When various tasks are progressing (also with tasks being queued) and the task panel is opened, there is a hang.
This happens when the task panel is opened (click on progress bar) and that the 3 active tasks are at 100%.
it is then needed to close and re-open the panel to see the updated state.

i have noticed this for the first time in the debug build.

Karim Alabtakh on May 28, 2018:

Done

Pierre henri Seylan on May 28, 2018:

The hang is no longer present but now there are other issues:
  • the layout is broken for queued tasks (see screenshot below)
  • the panel opens by itself, for example if you display another program window above the MPA while tasks are progressing, the tasks panel will appear on top of the other program 

Karim Alabtakh on May 28, 2018:

I see, this happen because we using popup component for that (which is not good because task panel should be updated)
actually I have found workaround and it work well on my side, but still case problems on your side

Pierre henri Seylan on May 28, 2018:


Now the app crashes when opening the task panel while multiple tasks are being performed 
https://www.dropbox.com/s/pzmswlo1cn5z00b/MPA%20crash%20closing%20tasks%20panel.rtf?dl=0

Karim Alabtakh on May 29, 2018:

I fixed the crash but other issues still often appear, the popup menu should be reimplemented, there is no way to update popup menu items, and my workaround solution doesn't work correctly

Pierre henri Seylan on May 29, 2018:

OK, 
Can you provide a rough estimation of how long would be needed to re-implement the popup including the UI? 
Maybe Daniel could do it, but he would need some instructions (he has implemented this version of the popup)

Also, maybe before starting re-implementing, can you revert all your changes for this issue and merge with the other branches? (Client-UI-Thanapong)

The point is, i have never noticed this issue before, so i'd like to make sure that it is also present after merging all branches.

I have made a video showing how it behaves in the other branch:
https://www.dropbox.com/s/efu2al9fg37nm7v/MPA%20tasks%20panel%20.mov?dl=0

Karim Alabtakh on May 29, 2018:

Not a lot, instead of using popup we should warp tasks components in custom scrolled component (like popular sounds in homepage and maybe we can use it if it's support scrolling) . It will take maybe 4h

Ok I will revert it now.

The problem is related to fact that popup menu block main thread. and async version in workaround solution not updated correctly.

I think that this problem appear when I fixed tasks assertion which may case crashes.
In old versions the task update UI from other thread.

Karim Alabtakh on June 6, 2018:

done

Pierre henri Seylan on June 6, 2018:

Feedback:

It works pretty well, just a small adjustment.
Let's display the panel a bit lower, it should actually start at the bottom of the main top bar so 50px below the upper border of the app.

Karim Alabtakh on June 9, 2018:

done