From the to-do list: MPA V1.0: API integration initial tasks
✔ Dynamic filters
(Completed by Pierre henri Seylan on February 28, 2019)
Comments
Pierre henri Seylan on November 19, 2018:
When filtering the sound library, it happens that the search results are empty.
This should no be the case as the filters panel should be updated with only filters which leads to a result. This was implemented in the previous version, and also on the website of the V3 (so the API should support it)
The idea is that when a filter is selected, all filters are updated to display only relevant filters. The relevant filters are the ones linked to the datas of the current search result, so that no filter leads to an empty list of result.
The only way to have empty search result is when using the text search.
Pierre henri Seylan on February 6, 2019:
Feedback:
Below are all the issues i've noticed with the dyamic filtering:
1. Clearing filters broken: (fixed) in list view, if you select more than 1 filter, clearing filters doesn't work correctly.
Test:
list view
Type: bass
Mood: bright
Then delete "bright", the search results are not updated
2. Logic for packs: (fixed) In the packs view, there is a bug with the search results. The filters are behaving in a "additive" fashion, instead of substractive like in list view.
Test:
pack view
Type: bell
This returns 2 results Then select "Mood = Creamy" It now retruns 4 results.
This means that it returns all results for "bell" and all results for "creamy" The correct behavior is that it retruns all results which contain both "bell" + "creamy"
3. Empty search results: (fixed) in packs view, there are some results which are incorrect:
Test:
pack view
Mood: Creamy
This returns 3 results. One of them has empty list of items when clicking on the pack "Synth rider" This means that the filtering algorithm is still buggy, probably on the server side.
4. Issue instanciating filters: (fixed) In the personal pack and list view, the filters are not correctly instanciated. They display all filter choices most of the time.
The correct behavior is that the filters choices are dynamically upated when going to those pages. This can be achieved by reseting the filters after following actions:
when opening the page/tab
after canceling filters search
after text search
this issue is still present, for example with user "test":
personal packs view
Mood: Sequence
It returns empty results, meaning that the filters are not updated properly when going to this view ("Sequence" should nnot appear if it has no results)
Pierre henri Seylan on February 13, 2019:
Feedback 2:
1. Bug clearing search: In the filters popups, the tag is not removed correctly if you click the items in the "active tags" section. It clears only when you click on the tag in the main section.
2.previous filters: There is a bug where the filters of the previous searches appear in the details pages. This is not easy to reproduce, but if you make a few different searches you should get the bug. I followed those steps:
Comments
Pierre henri Seylan on November 19, 2018:
This should no be the case as the filters panel should be updated with only filters which leads to a result.
This was implemented in the previous version, and also on the website of the V3 (so the API should support it)
The idea is that when a filter is selected, all filters are updated to display only relevant filters.
The relevant filters are the ones linked to the datas of the current search result, so that no filter leads to an empty list of result.
The only way to have empty search result is when using the text search.
Pierre henri Seylan on February 6, 2019:
Below are all the issues i've noticed with the dyamic filtering:
1. Clearing filters broken: (fixed)
in list view, if you select more than 1 filter, clearing filters doesn't work correctly.
Test:
- list view
- Type: bass
- Mood: bright
Then delete "bright", the search results are not updated2. Logic for packs: (fixed)
In the packs view, there is a bug with the search results.
The filters are behaving in a "additive" fashion, instead of substractive like in list view.
Test:
- pack view
- Type: bell
This returns 2 resultsThen select "Mood = Creamy"
It now retruns 4 results.
This means that it returns all results for "bell" and all results for "creamy"
The correct behavior is that it retruns all results which contain both "bell" + "creamy"
3. Empty search results: (fixed)
in packs view, there are some results which are incorrect:
Test:
- pack view
- Mood: Creamy
This returns 3 results.One of them has empty list of items when clicking on the pack "Synth rider"
This means that the filtering algorithm is still buggy, probably on the server side.
4. Issue instanciating filters: (fixed)
In the personal pack and list view, the filters are not correctly instanciated.
They display all filter choices most of the time.
The correct behavior is that the filters choices are dynamically upated when going to those pages.
This can be achieved by reseting the filters after following actions:
this issue is still present, for example with user "test":
- personal packs view
- Mood: Sequence
It returns empty results, meaning that the filters are not updated properly when going to this view ("Sequence" should nnot appear if it has no results)Pierre henri Seylan on February 13, 2019:
1. Bug clearing search:
In the filters popups, the tag is not removed correctly if you click the items in the "active tags" section.
It clears only when you click on the tag in the main section.
2.previous filters:
There is a bug where the filters of the previous searches appear in the details pages.
This is not easy to reproduce, but if you make a few different searches you should get the bug.
I followed those steps:
- go to personal tab
- use filters to filter content
- clear tags, start again
- after a few searches go to factory packs view
- make new search with filters
- go to a packs details page
The old tags from the previous searches appear in the packs details page.see the video below:
https://www.dropbox.com/s/h1ev6a1n5zprgn9/filters%20bug%202.mov?dl=0
3. Empty results:
I'm still getting empty results: