From the to-do list: MPA V1.0: API integration bugs and improvements
✔ Merge packs and collections tabs
(Completed by Pierre henri Seylan on April 3, 2019)
Comments
Pierre henri Seylan on February 5, 2019:
For a new update of the design, we have decided to go with only 1 factory tab, as it is less confusing. This means that both factory packs and collections will now be displayed in the "Factory" tab. The "Collections" tab will be removed.
The factory tab will now mix square ad rectangular images, as you can see in the screennshot below:
Before asking the UI devs to change the grid logic, it seems that it would be better to first put in place the backend logic.
1. Merge collections into Factory tab: The first step is to display the collections together with the sound packs in the factory tab. to do this, we should either send separate requests to get the packs and collections datas, or send a common request to get both packs and collections within 1 request. Decide which solution is the best and request the necessary changes to the web developers.
Once the API is ready, we should proceed with the integration. For now you can display the collection images as squares, so that it doesnt break the grid logic. The UI developer will then modify the grid logic to support both square and rectangular images.
2. Implement collections filter: We have added a dummy "Collections" filter in the "List by" popup. This should now be implemented. the idea is simple, when enabled it displays only the collections.
3. Complete and verify logic: The logic should be the same as before, the mixed packs and collections factory tab must support the same filtering options, such as:
List by: name, size, recent, popular
Filter by: main type, type, genre, mood, tempo, key
text search
Karim Alabtakh on March 11, 2019:
done
Pierre henri Seylan on March 12, 2019:
Feedback:
The main logic works well, however we have some bbugs with sorting and filtering, please check the issues below and report to the web developer when needed:
1. Sorting by size: When using this sorting option, some packs with 0 sounds appear before collections with dozens of sounds, it seems that it is sortinng the 2 types of ites separately. It does the same for sorting by name, and probably for recent and popularity as well
2. Filtering issues: With many filters combinations, empty results are returned for collections. See for example the screenshot below, the items display contains results matching the filters only for the pack's items (like "digital west coast") but all collections returned display no results when clicking on them.
Comments
Pierre henri Seylan on February 5, 2019:
This means that both factory packs and collections will now be displayed in the "Factory" tab.
The "Collections" tab will be removed.
The factory tab will now mix square ad rectangular images, as you can see in the screennshot below:
Before asking the UI devs to change the grid logic, it seems that it would be better to first put in place the backend logic.
1. Merge collections into Factory tab:
The first step is to display the collections together with the sound packs in the factory tab.
to do this, we should either send separate requests to get the packs and collections datas, or send a common request to get both packs and collections within 1 request.
Decide which solution is the best and request the necessary changes to the web developers.
Once the API is ready, we should proceed with the integration.
For now you can display the collection images as squares, so that it doesnt break the grid logic.
The UI developer will then modify the grid logic to support both square and rectangular images.
2. Implement collections filter:
We have added a dummy "Collections" filter in the "List by" popup.
This should now be implemented.
the idea is simple, when enabled it displays only the collections.
3. Complete and verify logic:
The logic should be the same as before, the mixed packs and collections factory tab must support the same filtering options, such as:
Karim Alabtakh on March 11, 2019:
Pierre henri Seylan on March 12, 2019:
The main logic works well, however we have some bbugs with sorting and filtering, please check the issues below and report to the web developer when needed:
1. Sorting by size:
When using this sorting option, some packs with 0 sounds appear before collections with dozens of sounds, it seems that it is sortinng the 2 types of ites separately.
It does the same for sorting by name, and probably for recent and popularity as well
2. Filtering issues:
With many filters combinations, empty results are returned for collections.
See for example the screenshot below, the items display contains results matching the filters only for the pack's items (like "digital west coast") but all collections returned display no results when clicking on them.