From the to-do list: MPA V1.0: post API integration
✔ Complete edit tags panel
(Completed by Pierre henri Seylan on July 16, 2019)
Comments
Pierre henri Seylan on February 28, 2019:
1. Add key: In the edit tag panel, there is a colum for "key" this column is still empty.
-Let's first populate this column with the choices provided by the API, basically the same as the ones used in the "Temp & key" filter panel.
-Then, we should add the possibility to assign a key tag to file. This works with the same logic as for other tags (in other columns) However, only 1 key can be assigned to a file, so when the user presses another key, it replaces the currently selected one (like "Loop" "One shots")
2. Sort instruments: The second column labeled "Instrument" is also empty. Here, we need to sort the tags to populate this list. The current logic is the following:
The API returns tags which have a certain type
The types are "Type 1", "Type 2", "Type 3", "Mood", "Genre"
Currently Type 2 and 3 are all displayed in the "Type" column
We should re-order the choices in the following manor:
Type 2 tags are listed in the "Type" column
Type 3 tags are listed in the "Instruments" column
Pierre henri Seylan on March 13, 2019:
hello,
are you sure that there are only 3 types of tags? see the screenshot of the server backend, there are type 2 and type 3 tags, as mentioned above. please double check
Daniel Ch. on March 13, 2019:
I agree that there are type 2 and type 3 tags, but I have a different image in postman after my request and I get it as a mix of type 2 and type 3. So, in general, we are getting all the tags by request, but then they are parsed into models (mood, genre, type), so that's why maybe in type we have a mix of type and instruments
Pierre henri Seylan on March 13, 2019:
ok, then i'll ask the web developer to sort them correctly
Pierre henri Seylan on April 25, 2019:
The tags types should now have been sorted by the web dev, please have a look again
Pierre henri Seylan on April 26, 2019:
Feedback:
It works well for the types. Please implement it for "Key" or let me know what changes are required on the server side.
Comments
Pierre henri Seylan on February 28, 2019:
1. Add key:
In the edit tag panel, there is a colum for "key"
this column is still empty.
-Let's first populate this column with the choices provided by the API, basically the same as the ones used in the "Temp & key" filter panel.
-Then, we should add the possibility to assign a key tag to file.
This works with the same logic as for other tags (in other columns)
However, only 1 key can be assigned to a file, so when the user presses another key, it replaces the currently selected one (like "Loop" "One shots")
2. Sort instruments:
The second column labeled "Instrument" is also empty.
Here, we need to sort the tags to populate this list.
The current logic is the following:
We should re-order the choices in the following manor:
Pierre henri Seylan on March 13, 2019:
are you sure that there are only 3 types of tags?
see the screenshot of the server backend, there are type 2 and type 3 tags, as mentioned above.
please double check
Daniel Ch. on March 13, 2019:
Pierre henri Seylan on March 13, 2019:
Pierre henri Seylan on April 25, 2019:
Pierre henri Seylan on April 26, 2019:
It works well for the types.
Please implement it for "Key" or let me know what changes are required on the server side.
Karim Alabtakh on July 10, 2019: